Runboard.com
You're welcome.
Runboard Extra! The Runboard Directory Runboard Knowledge Base

Ugly blue checkboxes in Chrome since the last update? checkbox

See how to fix it here!

Chat room Runboard Knowledge Base (wiki) Search Facebook Twitter





runboard.com       You are not logged in.

 
Pastor Rick Profile
Live feed
Blog
Friends
Miscellaneous info

Moderator

Registered: 07-2005
Location: Texas
Posts: 10245
Karma: 272 (+331/-59)
Reply | Quote
Blue Bullet bug fix


Blue Bullet was missing a div in the CLS which made the support/search box move down when you went to the view topics message area. I fixed it in the code yesterday but not on the testboard (since I do not have admin access).

---

Advertise Boards On TRDConceptsDE
3/7/2009, 2:59 am Link to post Email Pastor Rick   PM Pastor Rick Blog
 
Lesigner Girl Profile
Live feed
Blog
Friends
Miscellaneous info

Global Administrator
Head of Runboard staff

Registered: 11-2005
Posts: 25468
Karma: 426 (+479/-53)
Reply | Quote
Re: Blue Bullet bug fix


I assume you meant the </div> you added to the post that wasn't in the CLS?

While I was in the control panel just now, I closed all the line breaks and image tags that weren't closed.

Your post edit also mentions that you fixed the CSS. Do I need to fix something there too? I'd rather ask than comb through every line. emoticon

---
Runboard Knowledge Base
Runboard Support Forums
Find other message boards
3/7/2009, 3:21 am Link to post Email Lesigner Girl   PM Lesigner Girl Blog
 
Pastor Rick Profile
Live feed
Blog
Friends
Miscellaneous info

Moderator

Registered: 07-2005
Location: Texas
Posts: 10245
Karma: 272 (+331/-59)
Reply | Quote
Re: Blue Bullet bug fix


CSS fixes:

I added/* DEFINES BOX FOR LOCATION, SUPPORT & SEARCH */
#bnav {width: 100%; height: 50px; margin: 0.1em;; border: none; }


The following had to be changed (change in red):/* DEFINES BOX AROUND BOARD FORUM AND TOPIC NAME */
#location {
background-color : #ebebeb;
height : 49px;
width : 97%;
border : 1px solid #000000;
margin: 0 auto;
}

/* DEFINES BOX AROUND SUPPORT AND SEARCH LINKS */
#support {
background-color : #ebebeb;
height : 49px;
width : 100%;
border : 1px solid #000000;
font-size : 13px;
margin: 0 auto;
}

The <div></div> addition to the CLS location_boardlink: <div id="bnav"><div id="location"> <a href="%1">%2</a> <img src="http://rbbt.net/skins/joshin_josh/bluebullet/bullet.gif">

misc_simplesearch_link: <a href="%1">Search</a> </div></div>
Since my goal was to fix the obvious bug I wasn't looking for any other errors. You say you found some and fixed those as well?

EDIT: I also changed all img links from this: http://img247.imageshack.us/img247/7386/bulletea4.gif to this: http://rbbt.net/skins/joshin_josh/bluebullet/bullet.gif I think there was only one occurrence of a graphic still linked to imageshack and totally forgot to mention that one...

Last edited by Pastor Rick, 3/7/2009, 4:41 am


---

Advertise Boards On TRDConceptsDE
3/7/2009, 4:27 am Link to post Email Pastor Rick   PM Pastor Rick Blog
 
Lesigner Girl Profile
Live feed
Blog
Friends
Miscellaneous info

Global Administrator
Head of Runboard staff

Registered: 11-2005
Posts: 25468
Karma: 426 (+479/-53)
Reply | Quote
Re: Blue Bullet bug fix


Now I see why you added the </div>, but not only was it due to an unnecessary <div> that was added to the CLS, which can create some major errors.

Instead of adding div#location, .locationboard can and should be turned into a block-level element via CSS. I would also change div#support to span#support and use CSS to make that a block-level element, because block-level elements (div) should never be nested inside inline elements (span).

If you run that HTML through the validator, you'll see what I mean on all counts.

I would make the changes to the CSS as you posted, but I'd rather get the HTML right first, then change the CSS accordingly. I'll try to do that in the near future and then change the post accordingly, but I have another project I need to dedicate myself to this weekend.

---
Runboard Knowledge Base
Runboard Support Forums
Find other message boards
3/7/2009, 7:11 am Link to post Email Lesigner Girl   PM Lesigner Girl Blog
 
Pastor Rick Profile
Live feed
Blog
Friends
Miscellaneous info

Moderator

Registered: 07-2005
Location: Texas
Posts: 10245
Karma: 272 (+331/-59)
Reply | Quote
Re: Blue Bullet bug fix


quote:

Lesigner Girl wrote:

Now I see why you added the </div>, but not only was it due to an unnecessary <div> that was added to the CLS, which can create some major errors.

Instead of adding div#location, .locationboard can and should be turned into a block-level element via CSS. I would also change div#support to span#support and use CSS to make that a block-level element, because block-level elements (div) should never be nested inside inline elements (span).



I was wondering about the div#location and div#support but left that code alone under the premise that Josh still knows more than I do in many areas so he must have had a reason for it being there that I was just missing somehow.

quote:

Lesigner Girl wrote:
If you run that HTML through the validator, you'll see what I mean on all counts.

I would make the changes to the CSS as you posted, but I'd rather get the HTML right first, then change the CSS accordingly. I'll try to do that in the near future and then change the post accordingly, but I have another project I need to dedicate myself to this weekend.



So what you are saying is that while my patch to the code fixes the display problem observed what I should have done is run the code through the html validator first to see what the real problem was and then worked at fixing that instead.

---

Advertise Boards On TRDConceptsDE
3/7/2009, 11:33 am Link to post Email Pastor Rick   PM Pastor Rick Blog
 
Lesigner Girl Profile
Live feed
Blog
Friends
Miscellaneous info

Global Administrator
Head of Runboard staff

Registered: 11-2005
Posts: 25468
Karma: 426 (+479/-53)
Reply | Quote
Re: Blue Bullet bug fix


Josh is good with code, but he created that skin more than a year and a half ago and probably didn't know and/or think about using display:block; at the time, and I never looked closely enough to catch that before.

Just as you should always write the xHTML first, you should always make sure it's valid before moving on to the CSS.

---
Runboard Knowledge Base
Runboard Support Forums
Find other message boards
3/7/2009, 6:07 pm Link to post Email Lesigner Girl   PM Lesigner Girl Blog
 
Pastor Rick Profile
Live feed
Blog
Friends
Miscellaneous info

Moderator

Registered: 07-2005
Location: Texas
Posts: 10245
Karma: 272 (+331/-59)
Reply | Quote
Re: Blue Bullet bug fix


Just looking back abit... This one was a case where it should have been placed in as a <span id="whatever"></span> to work with the inline element of the CLS yes?

---

Advertise Boards On TRDConceptsDE
5/3/2009, 4:11 am Link to post Email Pastor Rick   PM Pastor Rick Blog
 
Lesigner Girl Profile
Live feed
Blog
Friends
Miscellaneous info

Global Administrator
Head of Runboard staff

Registered: 11-2005
Posts: 25468
Karma: 426 (+479/-53)
Reply | Quote
Re: Blue Bullet bug fix


Yes. Good catch. emoticon

---
Runboard Knowledge Base
Runboard Support Forums
Find other message boards
5/3/2009, 4:35 pm Link to post Email Lesigner Girl   PM Lesigner Girl Blog
 


Add a reply



You are not logged in (login)